helm: add keeper-metrics ServiceMonitor - #2048
Open
Slach wants to merge 1 commit into
Open
Conversation
serviceMonitor.enabled now also creates a separate ServiceMonitor that scrapes native ClickHouse Keeper prometheus endpoints from every keeper service managed by the operator (matched by clickhouse-keeper.altinity.com/app=chop label, port name `metrics`). Opt-out via serviceMonitor.keeperMetrics.enabled=false. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Slach
requested review from
alex-zaitsev and
sunsingerus
and removed request for
sunsingerus
July 28, 2026 13:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2038
serviceMonitor.enabledcreated a ServiceMonitor with onlych-metricsandop-metricsendpoints, so native Keeper prometheus metrics were not scraped.Since the existing ServiceMonitor selector targets the operator's own service, this adds a second ServiceMonitor
<fullname>-keeper-metricsunder the sameserviceMonitor.enabledflag:clickhouse-keeper.altinity.com/app: chop(label set by the operator on every keeper service)metrics(configurable viaserviceMonitor.keeperMetrics.port)namespaceSelector: {any: true}by default (CHK resources usually live outside the operator namespace), configurableserviceMonitor.keeperMetrics.enabled=false, plus the usualinterval,scrapeTimeout,relabelings,metricRelabelingsknobsKeeper itself must expose the prometheus endpoint via
prometheus/*settings in the CHK manifest and a namedmetricsport in its serviceTemplate. Clusters without Keeper are unaffected — the selector matches nothing.🤖 Generated with Claude Code